New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NameError fileno in gunicorn.http.wsgi #1178

Merged
merged 1 commit into from Jan 4, 2016

Conversation

Projects
None yet
4 participants
@tuco86
Contributor

tuco86 commented Jan 4, 2016

when fixing the fileno for BytesIO, actually setting fileno has been forogtten

tests said: 131 passed, 46 skipped

berkerpeksag added a commit that referenced this pull request Jan 4, 2016

Merge pull request #1178 from tuco86/master
Fix NameError fileno in gunicorn.http.wsgi

@berkerpeksag berkerpeksag merged commit 0ba74cf into benoitc:master Jan 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jan 4, 2016

Collaborator

Thanks!

Collaborator

berkerpeksag commented Jan 4, 2016

Thanks!

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jan 4, 2016

Owner

@berkerpeksag can you take care of a release? I'm not at my desk right now and will only be able to do it later tonight.

Owner

benoitc commented Jan 4, 2016

@berkerpeksag can you take care of a release? I'm not at my desk right now and will only be able to do it later tonight.

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jan 4, 2016

Collaborator

@benoitc I can do a release tomorrow morning if you think the patch is OK.

Collaborator

berkerpeksag commented Jan 4, 2016

@benoitc I can do a release tomorrow morning if you think the patch is OK.

@raphaelm

This comment has been minimized.

Show comment
Hide comment
@raphaelm

raphaelm Jan 5, 2016

Thanks for resolving this such quickly!

raphaelm commented Jan 5, 2016

Thanks for resolving this such quickly!

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jan 5, 2016

Owner

@berkerpeksag just did it. Thanks anyway :)

Owner

benoitc commented Jan 5, 2016

@berkerpeksag just did it. Thanks anyway :)

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Jan 5, 2016

Owner

@tuco86 @raphaelm release is now available.

Owner

benoitc commented Jan 5, 2016

@tuco86 @raphaelm release is now available.

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jan 5, 2016

Collaborator

Thanks!

Collaborator

berkerpeksag commented Jan 5, 2016

Thanks!

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1178 from tuco86/master
Fix NameError fileno in gunicorn.http.wsgi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment