Clean up traceback printing in arbitar #1201

Merged
merged 1 commit into from Feb 9, 2016

Projects

None yet

2 participants

@bloodearnest
Contributor

Currently, on some errors, tracebacks are manually included in the log message. This patch instead uses the stdlibs logging traceback printing. This allow better log customisation and control.

Additionally, because the call to logging.exception included the traceback in its log message, the traceback was printed twice the logs, as logging.exception always prints the traceback.

I've left the exceptions logged at debug/info as they are, but it seems to me they'd be better off as error level, since we sys.exit() after both anyway,

@benoitc
Owner
benoitc commented Feb 9, 2016

👍 can you rebase the commits in 1 ? will merge it right after.

@bloodearnest bloodearnest Let logging module handle traceback printing
Manually including the traceback in the log msg causes some issues when
interacting with log formats, and in one case was causing the traceback
to be printed twice.
0acfb55
@bloodearnest
Contributor

Done, thanks

@benoitc benoitc merged commit a3e3ee8 into benoitc:master Feb 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@benoitc
Owner
benoitc commented Feb 9, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment