New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$FORWARDED_ALLOW_IPS #1205

Merged
merged 2 commits into from Feb 11, 2016

Conversation

Projects
None yet
2 participants
@kennethreitz
Collaborator

kennethreitz commented Feb 11, 2016

This pull request gives gunicorn the ability to have the ForwardedAllowIPS setting (e.g. --forwarded-allow-ips) default configured via the environment variable FORWARDED_ALLOW_IPS. Similar behavior is currently in gunicorn for $WEB_CONCURRENCY and the Workers setting.

This will allow Heroku users to have a better default Gunicorn configuration out of the box, and will alleviate the need to use ProxyFix middleware in WSGI applications, without effecting their codebase.

🍰

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz
Collaborator

kennethreitz commented Feb 11, 2016

/cc @benoitc

benoitc added a commit that referenced this pull request Feb 11, 2016

@benoitc benoitc merged commit 7db09f1 into master Feb 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Feb 11, 2016

Owner

thanks!

Owner

benoitc commented Feb 11, 2016

thanks!

@kennethreitz

This comment has been minimized.

Show comment
Hide comment
@kennethreitz

kennethreitz Feb 11, 2016

Collaborator

@benoitc excellent, thanks! When is the planned-ish date for the next release?

Collaborator

kennethreitz commented Feb 11, 2016

@benoitc excellent, thanks! When is the planned-ish date for the next release?

@kennethreitz kennethreitz deleted the forwarded_allow_ips_env branch Feb 11, 2016

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment