fix infinite recursion when destroying sockets #1219

Merged
merged 1 commit into from Mar 13, 2016

Projects

None yet

2 participants

@tilgovi
Collaborator
tilgovi commented Mar 13, 2016

By having a getattr implementation that proxies to the sock
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to None.

@tilgovi tilgovi fix infinite recursion when destroying sockets
By having a `getattr` implementation that proxies to the `sock`
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to `None`.
e46dda7
@benoitc
Owner
benoitc commented Mar 13, 2016

+1

@tilgovi tilgovi merged commit 527dd7a into master Mar 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@tilgovi tilgovi deleted the fix/socket-destroy-recursion branch Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment