New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite recursion when destroying sockets #1219

Merged
merged 1 commit into from Mar 13, 2016

Conversation

Projects
None yet
2 participants
@tilgovi
Collaborator

tilgovi commented Mar 13, 2016

By having a getattr implementation that proxies to the sock
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to None.

fix infinite recursion when destroying sockets
By having a `getattr` implementation that proxies to the `sock`
attribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to `None`.
@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc
Owner

benoitc commented Mar 13, 2016

+1

tilgovi added a commit that referenced this pull request Mar 13, 2016

Merge pull request #1219 from benoitc/fix/socket-destroy-recursion
fix infinite recursion when destroying sockets

@tilgovi tilgovi merged commit 527dd7a into master Mar 13, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tilgovi tilgovi deleted the fix/socket-destroy-recursion branch Mar 13, 2016

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request #1219 from benoitc/fix/socket-destroy-recursion
fix infinite recursion when destroying sockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment