New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CWD and Python path before and after config #1481

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@tilgovi
Collaborator

tilgovi commented Mar 12, 2017

The config may be specified as a Python module, in which case we want
to ensure that the Python path is fixed up properly before we try to
load it. That means we should follow symlinks and add the current working
directory before and after the configuration is loaded.

Fix #1349

@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Mar 14, 2017

I don't understand the couverture report. It seems to be reporting that coverage improved, but the status hooks say it worsened.

@aconrad

This comment has been minimized.

Contributor

aconrad commented Mar 14, 2017

There might be a bug in the message saying that coverage has "worsened". What it really means in this case is that not all changes were tested, even though the overall coverage increased. (couverture encourages that all changes should be covered and doesn't satisfy itself by just looking at the overall code coverage)

Set CWD and Python path before and after config
The config may be specified as a Python module, in which case we want
to ensure that the Python path is fixed up properly before we try to
load it. That means we should follow symlinks and add the current working
directory before and after the configuration is loaded.

Fix #1349

@tilgovi tilgovi referenced this pull request Oct 27, 2017

Closed

release 19.8.0 #1634

@tilgovi tilgovi merged commit ccad26d into master Oct 28, 2017

2 of 9 checks passed

couverture-io/py26 Code coverage has worsened
Details
couverture-io/py27 Code coverage has worsened
Details
couverture-io/py34 Code coverage has worsened
Details
couverture-io/py35 Code coverage has worsened
Details
couverture-io/py36 Code coverage has worsened
Details
couverture-io/py36-dev Code coverage has worsened
Details
couverture-io/py37 Code coverage has worsened
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tilgovi tilgovi deleted the fix/1349-config-module-path branch Oct 28, 2017

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request benoitc#1481 from benoitc/fix/1349-config-module-path
Set CWD and Python path before and after config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment