New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use inotify on linux #1541

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@pjvandehaar
Contributor

pjvandehaar commented Jul 11, 2017

No description provided.

except ImportError:
has_inotify = False
has_inotify = False
if sys.platform == 'linux':

This comment has been minimized.

@berkerpeksag

berkerpeksag Jul 11, 2017

Collaborator

We still support Python 3.2 so

if sys.platform.startswith('linux'):
    ...

would be better.

This comment has been minimized.

@pjvandehaar

pjvandehaar Jul 11, 2017

Contributor

Good catch.

@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Jul 11, 2017

LGTM

@berkerpeksag berkerpeksag merged commit fc7c15a into benoitc:master Jul 12, 2017

0 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
couverture-io/py26 Verifying code coverage...
Details
couverture-io/py27 Verifying code coverage...
Details
couverture-io/py34 Verifying code coverage...
Details
couverture-io/py35 Verifying code coverage...
Details
couverture-io/py36 Verifying code coverage...
Details
couverture-io/py36-dev Verifying code coverage...
Details
couverture-io/py37 Verifying code coverage...
Details
@berkerpeksag

This comment has been minimized.

Collaborator

berkerpeksag commented Jul 12, 2017

Thanks!

@pjvandehaar pjvandehaar deleted the pjvandehaar:osx-no-inotify branch Jul 12, 2017

hramezani added a commit to hramezani/gunicorn that referenced this pull request Jul 15, 2017

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment