Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix #1576 - config file/module in GUNICORN_CMD_ARGS #1581
Looks mostly good. Thank you for writing tests, too! My only question is whether we should override
args.config so that we're consistent about precedence. But maybe config files are special and you could specify both? It seems overkill maybe, since you could always import one config from another.
I can kind of understand why overriding would make sense, but inheriting feels more natural to me.
After looking at this more I've realised the hierarchy feels a bit weird (as it was before the patch) as options from the config file on the command line are overridden by arguments from the environment:
This also gives the issue that applications don't get augments from the environment, so for applications to get configured properly