New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the gevent workers handle the usr1 signal by deferring to a new greenlet #1651

Merged
merged 2 commits into from Jan 25, 2018

Conversation

Projects
None yet
2 participants
@ant1g
Contributor

ant1g commented Nov 27, 2017

No description provided.

@ant1g

This comment has been minimized.

Contributor

ant1g commented Nov 27, 2017

Any suggestion on how to test this? I do not see any worker testing in the current unit tests.

@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Dec 10, 2017

I think this is fine. We don't have anything set up to test a worker receiving signals. We could construct a worker and mock some things, but this is simple to verify by reading and mirrors what we do for quit.

Would you mind adding the same to the eventlet worker and then we can merge this?

@ant1g

This comment has been minimized.

Contributor

ant1g commented Dec 17, 2017

Done! Let me know if anything else is needed!

@ant1g

This comment has been minimized.

Contributor

ant1g commented Jan 25, 2018

Hello,
Any chance for this to be merged soon?

Cheers

@tilgovi tilgovi merged commit d32f4ca into benoitc:master Jan 25, 2018

0 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
couverture-io/py26 Code coverage has worsened
Details
couverture-io/py27 Code coverage has worsened
Details
couverture-io/py34 Code coverage has worsened
Details
couverture-io/py35 Code coverage has worsened
Details
couverture-io/py36 Code coverage has worsened
Details
couverture-io/py36-dev Code coverage has worsened
Details
couverture-io/py37 Code coverage has worsened
Details
@tilgovi

This comment has been minimized.

Collaborator

tilgovi commented Jan 25, 2018

Done.

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Merge pull request benoitc#1651 from ant1g/fix/1645-gevent-handle_usr1
Make the gevent workers handle the usr1 signal by deferring to a new greenlet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment