New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1683 handle malformed basic auth header #1684

Merged
merged 3 commits into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@jeiting
Contributor

jeiting commented Jan 15, 2018

Fixes #1683

Added a unit test and tests pass on my branch.

Also tested against my server and confirmed the fix works.

@berkerpeksag

Thank you for adding a test case! :) I just made a small tweak to make the linter happy.

@berkerpeksag berkerpeksag merged commit f12ef22 into benoitc:master Jan 18, 2018

5 of 8 checks passed

couverture-io/py26 Not all changes are covered
Details
couverture-io/py27 Not all changes are covered
Details
couverture-io/py34 Not all changes are covered
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
couverture-io/py35 Code coverage OK
Details
couverture-io/py36 Code coverage OK
Details
couverture-io/py36-dev Code coverage OK
Details
couverture-io/py37 Code coverage OK
Details
@berkerpeksag

This comment has been minimized.

Collaborator

berkerpeksag commented Jan 18, 2018

Thanks!

andraiaallsop added a commit to andraiaallsop/gunicorn that referenced this pull request Mar 1, 2018

fofanov pushed a commit to fofanov/gunicorn that referenced this pull request Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment