New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the reopen_files by using FileHandler's method: close & _open #1742

Merged
merged 1 commit into from Apr 3, 2018

Conversation

Projects
None yet
2 participants
@ysymi
Contributor

ysymi commented Apr 3, 2018

Fix #1739

Reopen log files by using FileHandler's method, so that gunicorn can be compatible with different handler.

I tested this change on my handler, gunicorn reopen files as expected. Also tested by tox, and succeeded in py26, py27, py35 on my server .

@tilgovi

tilgovi approved these changes Apr 3, 2018

Thanks!

@tilgovi tilgovi merged commit 54e3b05 into benoitc:master Apr 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment