Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing zero bytes case in atoms access log #1787

Merged
merged 3 commits into from May 18, 2018

Conversation

Projects
None yet
2 participants
@yunstanford
Copy link
Contributor

yunstanford commented May 18, 2018

getattr(resp, 'sent', None) also means false if the value is 0.

.gitignore Outdated
@@ -5,6 +5,7 @@
.coverage
.pytest_cache
.tox
.cache

This comment has been minimized.

@tilgovi

tilgovi May 18, 2018

Collaborator

This is from an older version of pytest. The newer version is .pytest_cache and is already in this file. Pleas remove this when you can, thanks!

@tilgovi
Copy link
Collaborator

tilgovi left a comment

Looks great! Please ping this issue after you remove the .gitignore change and I'll merge it.

@yunstanford

This comment has been minimized.

Copy link
Contributor Author

yunstanford commented May 18, 2018

@tilgovi ok, updated .gitignore

@tilgovi

This comment has been minimized.

Copy link
Collaborator

tilgovi commented May 18, 2018

Thanks!

@tilgovi tilgovi merged commit d348430 into benoitc:master May 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.