Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
1795 rename async module #1796
Thanks! looks good for me, just wondering if the change should be major.
I don't think this is a major change since the chance of having worker subclasses is low and we are not the only project to make this change.
I'd vote +1 for adding this to the next 19.x release.
We don't have feature branches and develop features the way the Linux kernel team does (long lived branches, no intermediate commits etc.), so I think we can even disable the "create a merge commit" option.
I agree that we should avoid having fixup commits like that. They're not useful.
I don't "squash and merge" because sometimes the commits matter. I'll try to be more careful, though, and review the commits.
Maybe we can agree on a review process. When you give a
@berkerpeksag well we should probably have long lived branch. So we can break from now the code and work on next major release and start new iterations from it :) For example, I wouldn't have merged it before bumping our own version. That change will break anyone using a custom worker based on the async base. So that's a good call for such branches :)