test: unblock docker fixtures on macOS hosts#3622
Merged
Merged
Conversation
- per_app_allocation: move host port from 8001 to 28001. OrbStack reserves 8001 on macOS for vcom-tunnel which makes 'Bind: port already allocated' the default failure mode. - dirty_ttin_ttou: pin BASE_URL to 127.0.0.1 instead of 'localhost'. macOS resolves 'localhost' to ::1 first; Docker Desktop / OrbStack only forward host ports on IPv4 so the IPv6 attempt resets and the test fixture treats the service as unhealthy. - dirty_ttin_ttou: add setproctitle to the test image. The TTIN/TTOU tests count workers via 'pgrep -f dirty-worker', which only matches once gunicorn's util._setproctitle has actually renamed the processes.
- /unlimited and /limited handlers passed the data dict where the dirty client expected the action (method) name, surfacing as a 500 from getattr(self, action) on the dirty worker. Pass 'process' as the action so the call routes to DirtyApp.process(data). - TestUnlimitedApps now bumps worker count via TTIN and polls both apps for readiness before each test. The preceding TTOU-spam test pins the worker count at the LimitedTask floor (2) and the arbiter takes a moment to rebind apps to the surviving workers; the previous tests raced that rebind and saw 'No workers available'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three docker-fixture changes to make the suites runnable on a macOS host:
Linux CI runners aren't affected by either of the macOS port issues, but pinning IPv4 and adding the dependency makes the fixtures portable.