Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
gunicorn instrumentation via statsD and a new logger class #748
(This is another attempt at getting statsD instrumentation to gunicorn initially in #672)
What is this pull request?
statsd is the de facto low-overhead instrumentation of many web stacks. I have come across a number of different ways to instrument
I am hereby proposing that gunicorn optionally submits metrics to a local (or remote) statsD instance with the use of
Here is an example of such metric being graphed.
How does this work?
The arbiter and the base worker use a new logger that can take additional arguments to turn a log message into a metric. In addition certain known logging levels are automatically turned into metrics.
In particular the
The new logger class inherits from
Who is behind this?
A few questions:
The patch looks fine for me but I would change the way it is enabled before to integrate it. Instead of passing the class to the the logger class option and add an option to set the host I would automatically set the statd logger if the
If it's done until tomorrow we can include it in R19.0. If not it will wait the next one (planned this month or in july).
added a commit
this pull request
Jun 28, 2014
I can certainly stick it in the middle in the normal case, just after
In the case the statsd's implementation supports explicit tags (like