New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send statsd timing metrics in milliseconds #838

Merged
merged 2 commits into from Aug 5, 2014

Conversation

Projects
None yet
3 participants
@mgood
Contributor

mgood commented Aug 3, 2014

I was excited to see that gunicorn includes statsd reporting now, but I noticed that the times for request duration seemed quite low, and then noticed that it's sending times in seconds instead of milliseconds.

The statsd documentation indicates that timing values are expected to be in milliseconds:

"The glork took 320ms to complete this time"
https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing

I also confirmed that the Python statsd package is sending timing values in ms instead of s:

https://github.com/jsocol/pystatsd/blob/master/statsd/client.py#L30-L31

mgood added some commits Aug 3, 2014

Send statsd timing metrics in milliseconds
The statsd documentation indicates that timing values are expected to be in
milliseconds, not seconds:

  "The glork took 320ms to complete this time"
  https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing
@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Aug 4, 2014

Collaborator

@alq666 this look right to you?

Collaborator

tilgovi commented Aug 4, 2014

@alq666 this look right to you?

@alq666

This comment has been minimized.

Show comment
Hide comment
@alq666

alq666 Aug 4, 2014

Contributor

@tilgovi looks good to me

Contributor

alq666 commented Aug 4, 2014

@tilgovi looks good to me

tilgovi added a commit that referenced this pull request Aug 5, 2014

Merge pull request #838 from mgood/statsd-timing
Send statsd timing metrics in milliseconds

@tilgovi tilgovi merged commit 42ff88b into benoitc:master Aug 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@mgood mgood deleted the mgood:statsd-timing branch Aug 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment