Send statsd timing metrics in milliseconds #838

Merged
merged 2 commits into from Aug 5, 2014

Projects

None yet

3 participants

@mgood
Contributor
mgood commented Aug 3, 2014

I was excited to see that gunicorn includes statsd reporting now, but I noticed that the times for request duration seemed quite low, and then noticed that it's sending times in seconds instead of milliseconds.

The statsd documentation indicates that timing values are expected to be in milliseconds:

"The glork took 320ms to complete this time"
https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing

I also confirmed that the Python statsd package is sending timing values in ms instead of s:

https://github.com/jsocol/pystatsd/blob/master/statsd/client.py#L30-L31

mgood added some commits Aug 3, 2014
@mgood mgood Send statsd timing metrics in milliseconds
The statsd documentation indicates that timing values are expected to be in
milliseconds, not seconds:

  "The glork took 320ms to complete this time"
  https://github.com/etsy/statsd/blob/master/docs/metric_types.md#timing
7c10c7d
@mgood mgood Fix statsd test for millisecond times 59bf9b5
@tilgovi
Collaborator
tilgovi commented Aug 4, 2014

@alq666 this look right to you?

@alq666
Contributor
alq666 commented Aug 4, 2014

@tilgovi looks good to me

@tilgovi tilgovi merged commit 42ff88b into benoitc:master Aug 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@mgood mgood deleted the mgood:statsd-timing branch Aug 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment