Cut down logging messages in manage_workers #839

merged 3 commits into from Aug 5, 2014


None yet

2 participants

alq666 commented Aug 3, 2014

Fixes #834.

  1. Removes the logging of workers in manage_workers to keep log files lean.
  2. Allows metrics to be passed at all levels of logging (except access).
  3. Test reflects both changes.
@tilgovi tilgovi and 1 other commented on an outdated diff Aug 4, 2014
@@ -482,10 +482,10 @@ def manage_workers(self):
(pid, _) = workers.pop(0)
self.kill_worker(pid, signal.SIGTERM)
-"{0} workers".format(len(workers)),
- extra={"metric": "gunicorn.workers",
- "value": len(workers),
- "mtype": "gauge"})
+ self.log.debug("",
tilgovi Aug 4, 2014 Collaborator

Can we keep the message here? If debug log level is set it would be fine to show this in the log, I think.

alq666 Aug 4, 2014 Contributor

Sure thing, that's easy

tilgovi commented Aug 4, 2014


@tilgovi tilgovi merged commit 9c0add7 into benoitc:master Aug 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment