New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logconfig default to paster more trivially #941

Merged
merged 1 commit into from Nov 20, 2014

Conversation

Projects
None yet
3 participants
@tilgovi
Collaborator

tilgovi commented Nov 19, 2014

Rather than using fileConfig twice and risking different defaults
and behavior around disable_existing_loggers (ref #902), simply
set the default logging config file to be the paster config file
if it has a logger section and let glogging set up the rest.

@tilgovi

This comment has been minimized.

Show comment
Hide comment
@tilgovi

tilgovi Nov 19, 2014

Collaborator

This also ensures that the arbiter obeys the logging configuration when using paster. Prior to this, the paste config would be overwritten by glogging in the master, although the correct configuration was used in workers. So this fixes a real issue there, too.

Collaborator

tilgovi commented Nov 19, 2014

This also ensures that the arbiter obeys the logging configuration when using paster. Prior to this, the paste config would be overwritten by glogging in the master, although the correct configuration was used in workers. So this fixes a real issue there, too.

@benoitc

This comment has been minimized.

Show comment
Hide comment
@benoitc

benoitc Nov 19, 2014

Owner

+1 LGTM

Owner

benoitc commented Nov 19, 2014

+1 LGTM

Set logconfig default to paster more trivially
Rather than using fileConfig twice and risking different defaults
and behavior around disable_existing_loggers (ref #902), simply
set the default logging config file to be the paster config file
if it has a logger section and let glogging set up the rest.
@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Nov 20, 2014

Collaborator

LGTM.

Collaborator

berkerpeksag commented Nov 20, 2014

LGTM.

berkerpeksag added a commit that referenced this pull request Nov 20, 2014

Merge pull request #941 from benoitc/unify-paste-logging
Set logconfig default to paster more trivially

@berkerpeksag berkerpeksag merged commit fcb700c into master Nov 20, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@tilgovi tilgovi deleted the unify-paste-logging branch Nov 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment