Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
subclass Exception replace BaseException #997
All user-defined exceptions should also be derived from Exception
Well, I thought it was for to not catch HaltServer in gunicorn/arbiter.py explicitly, but I was wrong: https://github.com/benoitc/gunicorn/blob/master/gunicorn/arbiter.py#L200 Unless there is a reason to use BaseException, the patch LGTM.