Bd/test #1
Open
Bd/test #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hardcoded reference to the `origin` remote and instead implictly use the current commit or ref
The emoji in the github action name exposed as a env variable through docker was causing a gradle crash 😢.
Use action input `androidVersionCode` when provided. Generate the androidVersionCode from the version otherwise.
This helps avoid warnings when using previously undocumented inputs
After initial investigation, it seems https://gitlab.com/gableroux/unity3d/-/commit/4d1eaa74cbec79386cda4f797e1db63ebcda1c20 and related commits broke the unity-builder android builds. Unity is no longer able to find the Android Tools or the JDK. I was able to modify the Dockerfile to export an `ANDROID_HOME` env variable to get past the first issue but so far haven't found how to configure the Unity JDK location. Setting a `JAVA_HOME` env variable doesn't seem to help. Until we find a fix upstream (https://gitlab.com/gableroux/unity3d), pinning to an older version of the unity-3d image. We probably don't want to merge this since the image hash isn't going to work on all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.