Dev #72

Merged
merged 2 commits into from May 1, 2012

Projects

None yet

2 participants

@clifb
Contributor
clifb commented May 1, 2012

Hi, Ben,

I've made two changes in my fork that you may be interested in:

  • Added a Clear button to the filter dialog, to allow filters to be quickly removed.
  • Modified the lbTasks list box so that it continues to highlight the selected item when it loses focus, so that it's easier to see which item is selected when confirming deletion of a task.

These are done as separate commits, so it should be easy to pull one or the other if you wish.

Regards,
Clif

Clif Bromley added some commits Apr 26, 2012
Clif Bromley Added "Clear" button to filter dialog to provide a quick way of clear…
…ing all filters.
f8ccd38
Clif Bromley Changed tasks list box to retain selection highlight when losing focu…
…s, so that the selected item is more apparent when deleting a task.
a2a1509
@benrhughes
Owner

Excellent, thanks!

@benrhughes benrhughes merged commit a33dde6 into benrhughes:dev May 1, 2012
@benrhughes
Owner

Hi Clif,
For the most part this looks good. There's one small bug I've notice
though: when you have both vertical and horizontal scroll bars, a blue
square appears in the bottom right corner (see attached). I'm guessing
that this is related to your 'maintain highlight' change.

Any chance you can take a look at it?

Cheers,

Ben

On Wed, May 2, 2012 at 6:29 AM, Clif Bromley <
reply@reply.github.com>
wrote:

Hi, Ben,

I've made two changes in my fork that you may be interested in:

  • Added a Clear button to the filter dialog, to allow filters to be
    quickly removed.
  • Modified the lbTasks list box so that it continues to highlight the
    selected item when it loses focus, so that it's easier to see which item is
    selected when confirming deletion of a task.

These are done as separate commits, so it should be easy to pull one or
the other if you wish.

Regards,
Clif

You can merge this Pull Request by running:

git pull https://github.com/clifb/todotxt.net dev

Or you can view, comment on it, or merge it online at:

#72

-- Commit Summary --

  • Added "Clear" button to filter dialog to provide a quick way of
    clearing all filters.
  • Changed tasks list box to retain selection highlight when losing focus,
    so that the selected item is more apparent when deleting a task.

-- File Changes --

M Client/FilterDialog.xaml (5)
M Client/FilterDialog.xaml.cs (5)
M Client/MainWindow.xaml (4)

-- Patch Links --

https://github.com/benrhughes/todotxt.net/pull/72.patch
https://github.com/benrhughes/todotxt.net/pull/72.diff


Reply to this email directly or view it on GitHub:
#72

@clifb
Contributor
clifb commented May 2, 2012

Definitely. I'll take a look and get back to you.

Regards,
Clif
------Original Message------
From: Ben Hughes
To: Clif Bromley
Subject: Re: [todotxt.net] Dev (#72)
Sent: May 1, 2012 5:39 PM

Hi Clif,
For the most part this looks good. There's one small bug I've notice
though: when you have both vertical and horizontal scroll bars, a blue
square appears in the bottom right corner (see attached). I'm guessing
that this is related to your 'maintain highlight' change.

Any chance you can take a look at it?

Cheers,

Ben

On Wed, May 2, 2012 at 6:29 AM, Clif Bromley <
reply@reply.github.com>
wrote:

Hi, Ben,

I've made two changes in my fork that you may be interested in:

  • Added a Clear button to the filter dialog, to allow filters to be
    quickly removed.
  • Modified the lbTasks list box so that it continues to highlight the
    selected item when it loses focus, so that it's easier to see which item is
    selected when confirming deletion of a task.

These are done as separate commits, so it should be easy to pull one or
the other if you wish.

Regards,
Clif

You can merge this Pull Request by running:

git pull https://github.com/clifb/todotxt.net dev

Or you can view, comment on it, or merge it online at:

#72

-- Commit Summary --

  • Added "Clear" button to filter dialog to provide a quick way of
    clearing all filters.
  • Changed tasks list box to retain selection highlight when losing focus,
    so that the selected item is more apparent when deleting a task.

-- File Changes --

M Client/FilterDialog.xaml (5)
M Client/FilterDialog.xaml.cs (5)
M Client/MainWindow.xaml (4)

-- Patch Links --

https://github.com/benrhughes/todotxt.net/pull/72.patch
https://github.com/benrhughes/todotxt.net/pull/72.diff


Reply to this email directly or view it on GitHub:
#72


Reply to this email directly or view it on GitHub:
#72 (comment)

@clifb
Contributor
clifb commented May 2, 2012

Hi, Ben,

I looked into this last night and there doesn't seem to be a quick fix to eliminate that blue square. I tried a number of different approaches, but all introduced other display/rendering issues. It appears that I'll have to completely replace the ListBox and ListBoxItem styling templates to achieve the more visible inactive selection without side effects.

I will look into doing this, but for the time being, I think it's best to revert that particular change.

Is it easier for you to just revert/reject my patch or would you prefer that I send you a new pull request after I revert it in my fork? Whichever works best for you is fine with me.

Best regards,
Clif
-----Original Message-----
From: "Clif Bromley" chbromley@gmail.com
Date: Wed, 2 May 2012 00:40:37
To: Ben Hughesreply@reply.github.com
Reply-To: chbromley@gmail.com
Subject: Re: [todotxt.net] Dev (#72)

Definitely. I'll take a look and get back to you.

Regards,
Clif
------Original Message------
From: Ben Hughes
To: Clif Bromley
Subject: Re: [todotxt.net] Dev (#72)
Sent: May 1, 2012 5:39 PM

Hi Clif,
For the most part this looks good. There's one small bug I've notice
though: when you have both vertical and horizontal scroll bars, a blue
square appears in the bottom right corner (see attached). I'm guessing
that this is related to your 'maintain highlight' change.

Any chance you can take a look at it?

Cheers,

Ben

On Wed, May 2, 2012 at 6:29 AM, Clif Bromley <
reply@reply.github.com>
wrote:

Hi, Ben,

I've made two changes in my fork that you may be interested in:

  • Added a Clear button to the filter dialog, to allow filters to be
    quickly removed.
  • Modified the lbTasks list box so that it continues to highlight the
    selected item when it loses focus, so that it's easier to see which item is
    selected when confirming deletion of a task.

These are done as separate commits, so it should be easy to pull one or
the other if you wish.

Regards,
Clif

You can merge this Pull Request by running:

git pull https://github.com/clifb/todotxt.net dev

Or you can view, comment on it, or merge it online at:

#72

-- Commit Summary --

  • Added "Clear" button to filter dialog to provide a quick way of
    clearing all filters.
  • Changed tasks list box to retain selection highlight when losing focus,
    so that the selected item is more apparent when deleting a task.

-- File Changes --

M Client/FilterDialog.xaml (5)
M Client/FilterDialog.xaml.cs (5)
M Client/MainWindow.xaml (4)

-- Patch Links --

https://github.com/benrhughes/todotxt.net/pull/72.patch
https://github.com/benrhughes/todotxt.net/pull/72.diff


Reply to this email directly or view it on GitHub:
#72


Reply to this email directly or view it on GitHub:
#72 (comment)

@benrhughes
Owner

Hey Clif,
Thanks for looking into this. I agree that it sounds best to revert it. If
you don't mind, it think they easiest if you send a new pull request
removing that change.

Cheers,

Ben

On Thu, May 3, 2012 at 1:33 AM, Clif Bromley <
reply@reply.github.com

wrote:

Hi, Ben,

I looked into this last night and there doesn't seem to be a quick fix to
eliminate that blue square. I tried a number of different approaches, but
all introduced other display/rendering issues. It appears that I'll have to
completely replace the ListBox and ListBoxItem styling templates to achieve
the more visible inactive selection without side effects.

I will look into doing this, but for the time being, I think it's best to
revert that particular change.

Is it easier for you to just revert/reject my patch or would you prefer
that I send you a new pull request after I revert it in my fork? Whichever
works best for you is fine with me.

Best regards,
Clif
-----Original Message-----
From: "Clif Bromley" chbromley@gmail.com
Date: Wed, 2 May 2012 00:40:37
To: Ben Hughesreply@reply.github.com
Reply-To: chbromley@gmail.com
Subject: Re: [todotxt.net] Dev (#72)

Definitely. I'll take a look and get back to you.

Regards,
Clif
------Original Message------
From: Ben Hughes
To: Clif Bromley
Subject: Re: [todotxt.net] Dev (#72)
Sent: May 1, 2012 5:39 PM

Hi Clif,
For the most part this looks good. There's one small bug I've notice
though: when you have both vertical and horizontal scroll bars, a blue
square appears in the bottom right corner (see attached). I'm guessing
that this is related to your 'maintain highlight' change.

Any chance you can take a look at it?

Cheers,

Ben

On Wed, May 2, 2012 at 6:29 AM, Clif Bromley <
reply@reply.github.com>
wrote:

Hi, Ben,

I've made two changes in my fork that you may be interested in:

  • Added a Clear button to the filter dialog, to allow filters to be
    quickly removed.
  • Modified the lbTasks list box so that it continues to highlight the
    selected item when it loses focus, so that it's easier to see which item is
    selected when confirming deletion of a task.

These are done as separate commits, so it should be easy to pull one or
the other if you wish.

Regards,
Clif

You can merge this Pull Request by running:

git pull https://github.com/clifb/todotxt.net dev

Or you can view, comment on it, or merge it online at:

#72

-- Commit Summary --

  • Added "Clear" button to filter dialog to provide a quick way of
    clearing all filters.
  • Changed tasks list box to retain selection highlight when losing focus,
    so that the selected item is more apparent when deleting a task.

-- File Changes --

M Client/FilterDialog.xaml (5)
M Client/FilterDialog.xaml.cs (5)
M Client/MainWindow.xaml (4)

-- Patch Links --

https://github.com/benrhughes/todotxt.net/pull/72.patch
https://github.com/benrhughes/todotxt.net/pull/72.diff


Reply to this email directly or view it on GitHub:
#72


Reply to this email directly or view it on GitHub:
#72 (comment)


Reply to this email directly or view it on GitHub:
#72 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment