New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update suite to run against the latest #107
Conversation
We might want to update anolis and spec splitter etc etc? I guess by running make you've already got recent versions? |
So HTML doesn't use Anolis anymore. Wattsi is supposed to output a dev multipage version for you; you can see an older snapshot at https://html5.org/temp/multipage-dev.zip, or use Wattsi + build.sh to generate it directly. See more in #104 |
There's a lot here I'm not clear on, like how to get Wattsi's full-page version. After digging through https://github.com/whatwg/html-build/blob/master/build.sh I have more of an idea how this all sticks together, but there's so many different toolchains it might take some time.
502d5f7
to
27b7e19
Compare
Thanks for the fast response folks! Wasn't expecting anything back for a bit. To borrow from @benschwarz, is this the updated todo list?
|
I've reached the point where nothing crashes and it emits a zero error code on |
That sounds about right, although some of the tooling might be obsolete, e.g. the spec comes pre-split. So maybe along the lines of your "OR". On the other hand, if you get something working with updated content and auto-updating, that'll be a big improvement no matter the strategy :D |
Sounds good @CaseyLeask — I want to see the spec updated with the latest generated copy, then move to work on improving the tooling / generation / deployment, and then finally start working on the design and functionality of it. |
Thanks for the hard work so far @CaseyLeask 🐳 |
# item.remove | ||
# end | ||
# end | ||
#end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to get these disabled lines figured out? Any questions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove the extra charset specification, since we're adding our own from html/head.html. We can't remove the <meta http-equiv="Content-Type">, since there's a nokogiri bug coming from libxml2 that just re-adds it, even when we specify a valid <meta charset> sparklemotion/nokogiri#1008
|
6d30c01
to
aa384ff
Compare
🎉 |
@CaseyLeask let us know if you want us to generate something like https://html5.org/temp/multipage-dev.zip automatically and ping your build script somehow. That might be easier than running a fork of the build script and such. Filing an issue against https://github.com/whatwg/html-build once you're ready for that is probably easiest. (Thanks @benschwarz for pointing me towards this thread!) |
@annevk That sounds like a good idea. I'm using https://html5.org/temp/multipage-dev.zip in this version. I think I've still got a long way to go with this one. |
Note that we could also change https://github.com/whatwg/wattsi if the output for the developer edition is not great. Wattsi ultimately generates that so if there are things that are not usable we can simply change them. |
I'm keeping track of the issues in the branch, so I can keep a reasonable measure of progress. |
@CaseyLeask let us know if things would be better to update upstream. Since we already generate a multipage developer copy, tweaking that might be a better solution than post-processing. And ensure things stay synchronized. |
@annevk, the biggest blocker is the lack of the TOC… a few other details, but that's the big one |
The multipage-dev that whatwg/html-build generates and I posted an output copy from at https://html5.org/temp/multipage-dev.zip has both a TOC for all documents in |
@annevk Does it align with what's already deployed on developers.whatwg.org? |
I think that is definitely the intent, yes. It's basically the HTML standard without the sections marked as being specific to implementers (which we might not always annotate carefully since there's no current output to inspect, but we should fix that in the source document). I don't know how you got there prior to this point, but this seems like a good strategy. |
@CaseyLeask, I think we should merge what you have, then work on smaller specific issues from there, what's in master doesn't work at all, and this is at least half-way there. We can get it deploying to github pages etc, and start ironing out the kinks. Good with you? |
@benschwarz Good with me. |
[WIP] Update suite to run against the latest
Let us know when it's time to start setting up an automated system to deliver the dev version and deliver it to you. |
There's a lot here I'm not clear on, like how to get Wattsi's full-page
version. After digging through
https://github.com/whatwg/html-build/blob/master/build.sh I have more of
an idea how this all sticks together, but there's so many different
toolchains it might take some time.