From b3dd40dd90a2cc3d8b20c9c40662f9c038b0a353 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wojciech=20Wn=C4=99trzak?= <w.wnetrzak@gmail.com>
Date: Thu, 27 May 2021 01:56:06 +0200
Subject: [PATCH] Collapse params by default (#263)

Having expanded all of the params is very noisy. With this change we can also pack more jobs on page
---
 engine/app/controllers/good_job/dashboards_controller.rb | 2 +-
 engine/app/views/shared/_jobs_table.erb                  | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/engine/app/controllers/good_job/dashboards_controller.rb b/engine/app/controllers/good_job/dashboards_controller.rb
index c5b61d623..c01e26053 100644
--- a/engine/app/controllers/good_job/dashboards_controller.rb
+++ b/engine/app/controllers/good_job/dashboards_controller.rb
@@ -14,7 +14,7 @@ def last
       def jobs
         after_scheduled_at = params[:after_scheduled_at].present? ? Time.zone.parse(params[:after_scheduled_at]) : nil
         sql = GoodJob::Job.display_all(after_scheduled_at: after_scheduled_at, after_id: params[:after_id])
-                          .limit(params.fetch(:limit, 10))
+                          .limit(params.fetch(:limit, 25))
         sql = sql.with_job_class(params[:job_class]) if params[:job_class]
         if params[:state]
           case params[:state]
diff --git a/engine/app/views/shared/_jobs_table.erb b/engine/app/views/shared/_jobs_table.erb
index ec0cc57b3..09f849714 100644
--- a/engine/app/views/shared/_jobs_table.erb
+++ b/engine/app/views/shared/_jobs_table.erb
@@ -19,7 +19,13 @@
             <td><%= job.queue_name %></td>
             <td><%= job.scheduled_at || job.created_at %></td>
             <td><%= job.error %></td>
-            <td><pre><%= JSON.pretty_generate(job.serialized_params) %></pre></td>
+            <td>
+              <%= tag.button "Preview", type: "button", class: "btn btn-sm btn-outline-primary", role: "button",
+                data: {bs_toggle: "collapse", bs_target: "##{dom_id(job, 'params')}"},
+                aria: {expanded: false, controls: dom_id(job, "params")}
+              %>
+              <%= tag.pre JSON.pretty_generate(job.serialized_params), id: dom_id(job, "params"), class: "collapse" %>
+            </td>
           </tr>
         <% end %>
       </tbody>