Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
fix web-runner #3
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Can you post a gist of a file that logs to stdout and breaks runFile? I can't reproduce that. At this point runFile's implementation is very simple and straight-forward and I'm reluctant to make it do more unless it is absolutely necessary. I actually have a patch in the works that allows people running runFile to catch the stdout of a suite (looks like this https://gist.github.com/704636) to give suite runners full control over how a suite is being outputted. I think this is great, and don't want to have stdout automatically get printed if we can avoid it.
If stdout messages are getting confused as encoded messages then we should probably just make coded messages more unique.
also, since it depends on new lines,
it will prevent the next message from getting through... which is surely onTestDone
... i have a test which checks that onTestStart, onTestDone, and onSuiteDone are all called correctly.
you can break it by adding require('util').print("xxxxxx") into a test in the test/examples directory.
runFile IS simple, i got a bit carried away yesterday, trying to rewrite it with http.
I learnt much more about http than i knew before,