Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import base module in proto generated py code #250

Merged
merged 3 commits into from Aug 6, 2019

Conversation

@parano
Copy link
Member

commented Aug 6, 2019

  • updated proto generate script
  • removed generated mypy stub files
@codecov-io

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   51.97%   51.97%           
=======================================
  Files          67       67           
  Lines        3621     3621           
=======================================
  Hits         1882     1882           
  Misses       1739     1739
Impacted Files Coverage Δ
bentoml/proto/yatai_service_pb2.py 0% <0%> (ø) ⬆️
bentoml/proto/yatai_service_pb2_grpc.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c85d1a4...56fed2c. Read the comment docs.

@parano parano merged commit 6180555 into bentoml:master Aug 6, 2019

2 of 3 checks passed

codecov/patch 0% of diff hit (target 51.97%)
Details
codecov/project 51.97% remains the same compared to c85d1a4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.