Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generated YataiServicer interface for deployment RPCs #251

merged 5 commits into from Aug 6, 2019


Copy link

commented Aug 6, 2019

No description provided.


This comment has been minimized.

Copy link

commented Aug 6, 2019

Hello @parano! Thanks for opening this PR.

Line 39:1: E302 expected 2 blank lines, found 1

Do see the Hitchhiker's guide to code style


This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #251      +/-   ##
- Coverage   51.97%   51.78%   -0.19%     
  Files          67       67              
  Lines        3621     3634      +13     
  Hits         1882     1882              
- Misses       1739     1752      +13
Impacted Files Coverage Δ
bentoml/ 85.41% <ø> (ø) ⬆️
bentoml/yatai/ 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6180555...a79c432. Read the comment docs.

@parano parano merged commit 684aee7 into bentoml:master Aug 6, 2019

1 of 3 checks passed

codecov/patch 0% of diff hit (target 51.97%)
codecov/project 51.78% (-0.19%) compared to 6180555
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.