Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli config subcommand #252

Merged
merged 5 commits into from Aug 6, 2019

Conversation

@yubozhao
Copy link
Member

commented Aug 6, 2019

What changes were proposed in this pull request?

Use subcommand pattern for bentoml config operations

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 6, 2019

Hello @yubozhao, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2019-08-06 20:51:54 UTC

@yubozhao yubozhao requested a review from parano Aug 6, 2019

add_configuration_commands(_cli)

# pylint: enable=unused-variable
add_configuration_sub_commands(_cli)

This comment has been minimized.

Copy link
@parano

parano Aug 6, 2019

Member
config_command = get_config_sub_command()
_cli.add_command(...)

This comment has been minimized.

Copy link
@yubozhao

yubozhao Aug 6, 2019

Author Member

done

yubozhao added 2 commits Aug 6, 2019

@yubozhao yubozhao merged commit e3fef3a into bentoml:master Aug 6, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@yubozhao yubozhao deleted the yubozhao:cli-config-subcommand branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.