Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using versioneer for managing BentoML version #253

Merged
merged 10 commits into from Aug 7, 2019

Conversation

@parano
Copy link
Member

commented Aug 6, 2019

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 6, 2019

Hello @parano, Thanks for updating this PR.

Line 564:35: W605 invalid escape sequence '\s'
Line 568:35: W605 invalid escape sequence '\s'
Line 572:35: W605 invalid escape sequence '\s'
Line 613:52: W605 invalid escape sequence '\d'
Line 689:33: W605 invalid escape sequence '\d'

Comment last updated at 2019-08-06 23:48:27 UTC
@parano

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

ignoring pep8speaks's comment since versioneer.py is not our code -

parano added some commits Aug 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@e3fef3a). Click here to learn what that means.
The diff coverage is 42.19%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #253   +/-   ##
========================================
  Coverage          ?   51.1%           
========================================
  Files             ?      67           
  Lines             ?    3919           
  Branches          ?       0           
========================================
  Hits              ?    2003           
  Misses            ?    1916           
  Partials          ?       0
Impacted Files Coverage Δ
bentoml/deployment/operator.py 39.28% <ø> (ø)
bentoml/__init__.py 100% <100%> (ø)
bentoml/service_env.py 72.8% <100%> (ø)
bentoml/archive/config.py 88.23% <100%> (ø)
bentoml/_version.py 41.15% <41.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fef3a...1d9ed37. Read the comment docs.

@parano parano merged commit eaac7c7 into bentoml:master Aug 7, 2019

3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.