Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yatai deployment service implementation WIP #262

Merged
merged 16 commits into from Aug 14, 2019

Conversation

@parano
Copy link
Member

commented Aug 14, 2019

No description provided.

@pep8speaks

This comment has been minimized.

Copy link

commented Aug 14, 2019

Hello @parano, Thanks for updating this PR.

Line 351:9: F841 local variable 'bento_path' is assigned to but never used

Comment last updated at 2019-08-14 22:17:39 UTC
@codecov-io

This comment has been minimized.

Copy link

commented Aug 14, 2019

Codecov Report

Merging #262 into master will increase coverage by 4.76%.
The diff coverage is 40.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage    50.4%   55.16%   +4.76%     
==========================================
  Files          68       68              
  Lines        3984     4169     +185     
==========================================
+ Hits         2008     2300     +292     
+ Misses       1976     1869     -107
Impacted Files Coverage Δ
bentoml/proto/yatai_service_pb2.py 100% <100%> (+100%) ⬆️
bentoml/proto/deployment_pb2.py 100% <100%> (ø) ⬆️
bentoml/exceptions.py 100% <100%> (ø) ⬆️
bentoml/db.py 50% <14.28%> (+50%) ⬆️
bentoml/yatai/__init__.py 32.29% <27.84%> (+32.29%) ⬆️
bentoml/deployment/store.py 40.5% <35.61%> (+40.5%) ⬆️
bentoml/deployment/sagemaker/__init__.py 24.34% <38.46%> (-0.66%) ⬇️
bentoml/deployment/operator.py 50% <46.66%> (+10.71%) ⬆️
bentoml/repository/__init__.py 61.01% <56.86%> (+61.01%) ⬆️
bentoml/service.py 85.42% <85.71%> (+0.01%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e371421...25d751c. Read the comment docs.

bentoml/deployment/store.py Outdated Show resolved Hide resolved

@yubozhao yubozhao added the LGTM label Aug 14, 2019

parano added 4 commits Aug 14, 2019

@parano parano merged commit 5675303 into bentoml:master Aug 14, 2019

2 of 3 checks passed

codecov/patch 40.16% of diff hit (target 50.4%)
Details
codecov/project 55.16% (+4.76%) compared to e371421
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.