Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quick-start guide for coming release & MISC #295

Merged
merged 15 commits into from Sep 17, 2019

Conversation

@parano
Copy link
Member

commented Sep 17, 2019

  • Update quick-start guide for coming release
  • Updated CLI info command to include more metadata in output, format matching BentoServiceMetadata protobuf definition
  • Renaming 'bentoml docs' command to 'bentoml open-api-spec'
  • use - instead of _ in deployment CLI options
  • fixed ALL linter errors

image

@pep8speaks

This comment has been minimized.

Copy link

commented Sep 17, 2019

Hello @parano, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2019-09-17 01:25:18 UTC
@parano parano merged commit c4482a0 into bentoml:master Sep 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@codecov-io

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #295 into master will increase coverage by 1.15%.
The diff coverage is 51.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   51.67%   52.82%   +1.15%     
==========================================
  Files          74       74              
  Lines        4809     4812       +3     
==========================================
+ Hits         2485     2542      +57     
+ Misses       2324     2270      -54
Impacted Files Coverage Δ
bentoml/repository/metadata_store.py 60.71% <ø> (ø) ⬆️
bentoml/deployment/store.py 42.35% <ø> (ø) ⬆️
bentoml/utils/usage_stats.py 84.21% <ø> (ø) ⬆️
bentoml/yatai/yatai_service_impl.py 37.5% <ø> (ø) ⬆️
bentoml/__init__.py 100% <ø> (ø) ⬆️
bentoml/yatai/python_api.py 90% <ø> (ø) ⬆️
bentoml/cli/config.py 29.54% <ø> (ø) ⬆️
bentoml/deployment/clipper/__init__.py 0% <0%> (ø) ⬆️
bentoml/deployment/sagemaker/__init__.py 0% <0%> (ø) ⬆️
bentoml/proto/deployment_pb2.py 100% <100%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf4139...536fd7c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.