Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring sagemaker deployment experience #328

Merged
merged 10 commits into from Oct 9, 2019

Conversation

@yubozhao
Copy link
Member

commented Oct 8, 2019

No description provided.

@pep8speaks

This comment has been minimized.

Copy link

commented Oct 8, 2019

Hello @yubozhao, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2019-10-09 01:30:15 UTC
@codecov-io

This comment has been minimized.

Copy link

commented Oct 8, 2019

Codecov Report

Merging #328 into master will decrease coverage by 0.13%.
The diff coverage is 26.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
- Coverage   54.67%   54.53%   -0.14%     
==========================================
  Files          75       76       +1     
  Lines        5081     5105      +24     
==========================================
+ Hits         2778     2784       +6     
- Misses       2303     2321      +18
Impacted Files Coverage Δ
bentoml/deployment/serverless/serverless_utils.py 0% <ø> (ø) ⬆️
bentoml/repository/__init__.py 63.88% <ø> (-0.5%) ⬇️
bentoml/yatai/yatai_service_impl.py 35.66% <0%> (ø) ⬆️
bentoml/deployment/serverless/gcp_function.py 0% <0%> (ø) ⬆️
bentoml/deployment/serverless/aws_lambda.py 0% <0%> (ø) ⬆️
bentoml/cli/deployment.py 37.5% <12.5%> (+0.35%) ⬆️
bentoml/deployment/sagemaker/__init__.py 20.25% <29.03%> (-1.71%) ⬇️
bentoml/cli/utils.py 29.78% <29.78%> (ø)
bentoml/deployment/utils.py 56.45% <33.33%> (+1.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8a0ba...48eda2b. Read the comment docs.

@yubozhao yubozhao merged commit a4448da into bentoml:master Oct 9, 2019
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.