Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment readme for sagemaker and lambda #352

Merged
merged 4 commits into from Oct 18, 2019

Conversation

@yubozhao
Copy link
Member

yubozhao commented Oct 17, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #352 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   53.65%   53.65%           
=======================================
  Files          78       78           
  Lines        5248     5248           
=======================================
  Hits         2816     2816           
  Misses       2432     2432
Impacted Files Coverage Δ
bentoml/deployment/sagemaker/__init__.py 20.16% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70166d...9d9e679. Read the comment docs.

@parano parano merged commit 84a0b89 into bentoml:master Oct 18, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 53.65%)
Details
codecov/project 53.65% remains the same compared to c70166d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@@ -291,7 +291,7 @@ def apply(self, deployment_pb, yatai_service, prev_deployment=None):
sagemaker_client = boto3.client('sagemaker', sagemaker_config.region)

with TempDirectory() as temp_dir:
sagemaker_project_dir = os.path.jon(
sagemaker_project_dir = os.path.join(

This comment has been minimized.

Copy link
@ghunkins

ghunkins Oct 20, 2019

Contributor

Was going to open an issue on this, great to see this fixed 👍

This comment has been minimized.

Copy link
@yubozhao

yubozhao Oct 21, 2019

Author Member

Yeah. My b on that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.