Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BentoService bundle pip package dependencies #396

Merged
merged 3 commits into from Nov 25, 2019

Conversation

@parano
Copy link
Member

parano commented Nov 25, 2019

What changes were proposed in this pull request?

This PR fixed the issue posted at #395 - when using BentoService bundle as a PyPI package, it failed to set the list of pip dependencies as the install_requires field in setup.py

Does this close any currently open issues?

#395

How was this patch tested?

unit test, manually tested locally

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 25, 2019

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #396   +/-   ##
======================================
  Coverage    59.8%   59.8%           
======================================
  Files          81      81           
  Lines        5408    5408           
======================================
  Hits         3234    3234           
  Misses       2174    2174
Impacted Files Coverage Δ
bentoml/bundler/templates.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 791312c...4624db0. Read the comment docs.

@parano parano merged commit 94d9271 into bentoml:master Nov 25, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 791312c...4624db0
Details
codecov/project 59.8% remains the same compared to 791312c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.