Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda Deployment misc improvements #407

Merged
merged 2 commits into from Nov 28, 2019

Conversation

@parano
Copy link
Member

parano commented Nov 27, 2019

  • Delete deployment record when it failed to create related cloud resources
  • Improved error message
parano added 2 commits Nov 27, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #407 into master will decrease coverage by 0.05%.
The diff coverage is 34.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   59.28%   59.23%   -0.06%     
==========================================
  Files          85       85              
  Lines        5769     5779      +10     
==========================================
+ Hits         3420     3423       +3     
- Misses       2349     2356       +7
Impacted Files Coverage Δ
bentoml/deployment/utils.py 56.36% <ø> (ø) ⬆️
bentoml/cli/deployment.py 36.68% <0%> (-0.76%) ⬇️
bentoml/yatai/yatai_service_impl.py 34.81% <0%> (-1.86%) ⬇️
bentoml/deployment/aws_lambda/__init__.py 64.28% <22.22%> (-0.09%) ⬇️
bentoml/deployment/aws_lambda/utils.py 43.9% <50%> (-0.82%) ⬇️
bentoml/yatai/python_api.py 57.43% <51.51%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b646ec3...1c7dd73. Read the comment docs.

@parano parano merged commit 0e04540 into bentoml:master Nov 28, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 34.48% of diff hit (target 59.28%)
Details
codecov/project 59.23% (-0.06%) compared to b646ec3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.