Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: tf_savedmodel_artifact docstring #408

Merged
merged 1 commit into from Nov 28, 2019
Merged

doc: tf_savedmodel_artifact docstring #408

merged 1 commit into from Nov 28, 2019

Conversation

@hrmthw
Copy link
Collaborator

hrmthw commented Nov 28, 2019

(Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below.)

What changes were proposed in this pull request?

  • modify the docstring in tf_savedmodel_artifact.py, describe the usage of two kinds of TensorFlow Module

Does this close any currently open issues?

no

How was this patch tested?

--

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Nov 28, 2019

Hello @hrmthw, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2019-11-28 03:09:33 UTC
@hrmthw hrmthw force-pushed the hrmthw:dev branch from 9e1e57b to d6c9512 Nov 28, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #408 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
+ Coverage   59.07%   59.23%   +0.15%     
==========================================
  Files          85       85              
  Lines        5779     5779              
==========================================
+ Hits         3414     3423       +9     
+ Misses       2365     2356       -9
Impacted Files Coverage Δ
bentoml/artifact/tf_savedmodel_artifact.py 37.7% <ø> (ø) ⬆️
bentoml/configuration/__init__.py 90% <0%> (+1.42%) ⬆️
bentoml/_version.py 44.4% <0%> (+1.8%) ⬆️
bentoml/bundler/config.py 93.25% <0%> (+3.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e04540...d6c9512. Read the comment docs.

@parano parano merged commit 40c7c44 into bentoml:master Nov 28, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 0e04540...d6c9512
Details
codecov/project 59.23% (+0.15%) compared to 0e04540
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.