Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement deployment update for sagemaker #461

Merged
merged 21 commits into from Jan 9, 2020

Conversation

@yubozhao
Copy link
Member

yubozhao commented Jan 7, 2020

(Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below.)

What changes were proposed in this pull request?

Does this close any currently open issues?

How was this patch tested?

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jan 7, 2020

Hello @yubozhao, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-01-09 22:27:22 UTC
@yubozhao yubozhao force-pushed the yubozhao:implment-sagemaker-update branch from 178bc87 to 30af07b Jan 7, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 7, 2020

Codecov Report

Merging #461 into master will increase coverage by <.01%.
The diff coverage is 43.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   57.82%   57.83%   +<.01%     
==========================================
  Files          84       84              
  Lines        5812     5936     +124     
==========================================
+ Hits         3361     3433      +72     
- Misses       2451     2503      +52
Impacted Files Coverage Δ
bentoml/deployment/operator.py 51.72% <ø> (ø) ⬆️
bentoml/utils/validator/__init__.py 95.45% <100%> (ø) ⬆️
bentoml/yatai/deployment_utils.py 86.27% <100%> (ø) ⬆️
bentoml/yatai/yatai_service_impl.py 35.22% <20%> (-0.23%) ⬇️
bentoml/cli/deployment.py 36.13% <27.77%> (-1.49%) ⬇️
bentoml/yatai/python_api.py 49.14% <3.22%> (-9.77%) ⬇️
bentoml/deployment/sagemaker/__init__.py 75.4% <73.33%> (+7.39%) ⬆️
bentoml/bundler/templates.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7aed79...d7c2388. Read the comment docs.

@yubozhao yubozhao force-pushed the yubozhao:implment-sagemaker-update branch from 30af07b to 2102c89 Jan 8, 2020
@yubozhao yubozhao marked this pull request as ready for review Jan 8, 2020
@yubozhao yubozhao requested a review from parano Jan 8, 2020
yubozhao added 6 commits Jan 8, 2020
CLI_COLOR_ERROR,
)
return
current_deployment = get_deployment_result.deployment

This comment has been minimized.

Copy link
@parano

parano Jan 9, 2020

Member

this logic should not be in CLI, move them to yataiservice python_api

yubozhao added 2 commits Jan 9, 2020
@parano parano merged commit 78de8cf into bentoml:master Jan 9, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 43.7% of diff hit (target 57.82%)
Details
codecov/project 57.83% (+<.01%) compared to f0437c3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.