Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete bento services after complete e2e tests #503

Merged
merged 4 commits into from Feb 4, 2020

Conversation

@yubozhao
Copy link
Member

yubozhao commented Jan 27, 2020

No description provided.

@yubozhao yubozhao requested a review from parano Jan 27, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #503 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #503      +/-   ##
==========================================
+ Coverage   56.29%   56.42%   +0.13%     
==========================================
  Files          89       89              
  Lines        6402     6408       +6     
==========================================
+ Hits         3604     3616      +12     
+ Misses       2798     2792       -6
Impacted Files Coverage Δ
bentoml/handlers/dataframe_handler.py 83.33% <0%> (-0.71%) ⬇️
bentoml/yatai/yatai_service_impl.py 35.18% <0%> (ø) ⬆️
.../deployment/aws_lambda/download_extra_resources.py 0% <0%> (ø) ⬆️
bentoml/deployment/aws_lambda/lambda_app.py 91.17% <0%> (+0.55%) ⬆️
bentoml/configuration/__init__.py 88.73% <0%> (+1.4%) ⬆️
bentoml/_version.py 44.4% <0%> (+1.8%) ⬆️
bentoml/bundler/config.py 94.5% <0%> (+3.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b30c1a...5268d18. Read the comment docs.

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Jan 31, 2020

Hello @yubozhao, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-01-31 07:53:48 UTC
@yubozhao yubozhao requested a review from parano Jan 31, 2020
@yubozhao yubozhao merged commit d82c2f1 into bentoml:master Feb 4, 2020
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing 4b30c1a...5268d18
Details
codecov/project 56.42% (+0.13%) compared to 4b30c1a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.