Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement micro batching support for tf tensor handler #533

Merged
merged 4 commits into from Feb 13, 2020
Merged

Conversation

@hrmthw
Copy link
Collaborator

hrmthw commented Feb 13, 2020

(Thanks for sending a pull request! Please make sure to read the contribution guidelines, then fill out the blanks below.)

What changes were proposed in this pull request?

implement micro batching support for tf tensor handler

Does this close any currently open issues?

no

How was this patch tested?

@pep8speaks

This comment has been minimized.

Copy link

pep8speaks commented Feb 13, 2020

Hello @hrmthw, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2020-02-13 04:22:58 UTC
@hrmthw hrmthw force-pushed the hrmthw:tf branch from ab9dee5 to 0810f21 Feb 13, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Feb 13, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@d95a887). Click here to learn what that means.
The diff coverage is 34.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #533   +/-   ##
=========================================
  Coverage          ?   55.79%           
=========================================
  Files             ?       93           
  Lines             ?     6775           
  Branches          ?        0           
=========================================
  Hits              ?     3780           
  Misses            ?     2995           
  Partials          ?        0
Impacted Files Coverage Δ
bentoml/marshal/marshal.py 27.47% <0%> (ø)
bentoml/marshal/utils.py 24% <0%> (ø)
bentoml/handlers/tensorflow_tensor_handler.py 43.33% <10.81%> (ø)
bentoml/handlers/utils.py 93.1% <100%> (ø)
bentoml/handlers/fastai_image_handler.py 24.27% <33.33%> (ø)
bentoml/handlers/json_handler.py 78.04% <50%> (ø)
bentoml/handlers/image_handler.py 91.25% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95a887...3a1672d. Read the comment docs.

@hrmthw hrmthw changed the title implement micro batching support for tensorflow_tensor_handler implement micro batching support for tf tensor handler Feb 13, 2020
@hrmthw hrmthw requested a review from parano Feb 13, 2020
@parano
parano approved these changes Feb 13, 2020
@parano parano merged commit 769ff01 into bentoml:master Feb 13, 2020
3 checks passed
3 checks passed
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hrmthw added a commit to hrmthw/BentoML that referenced this pull request Feb 13, 2020
* implement micro batching support for tensorflow_tensor_handler

* fix bare except

* style: format with black

* make linter happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.