New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArrayBuffer cloning (util.clone) #59

Merged
merged 1 commit into from Sep 27, 2011

Conversation

Projects
None yet
2 participants
@bpl
Contributor

bpl commented Aug 7, 2011

Util.clone wasn't able to clone an ArrayBuffer. Firstly, it referenced non-existent variable source when it seems that arg was actually meant. Secondly, DataView methods setUint8 and getUint8 were wrongly capitalized.

This should also fix issue #55.

Fix ArrayBuffer cloning (util.clone)
Util.clone wasn't able to clone an ArrayBuffer. Firstly, it referenced
non-existent variable "source" when it seems that "arg" was actually meant.
Secondly, DataView methods setUint8 and getUint8 were wrongly capitalized.

The third change (target.byteLength -> arg.byteLength) is just for
consistency.

benvanik added a commit that referenced this pull request Sep 27, 2011

Merge pull request #59 from bpl/master
Fix ArrayBuffer cloning (util.clone)

@benvanik benvanik merged commit 209ca93 into benvanik:master Sep 27, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment