Permalink
Browse files

Don't discard stdout when running premake (hiding important errors)

1 parent 9457c63 commit 20458de7524a126c7cebeffa5d804d389e5a912a @DrChat DrChat committed Sep 9, 2016
Showing with 5 additions and 3 deletions.
  1. +5 −3 xenia-build
View
@@ -315,7 +315,7 @@ def run_premake(target_os, action):
target_os: target --os to pass to premake.
action: action to preform.
"""
- shell_call([
+ ret = subprocess.call([
'python',
os.path.join('tools', 'build', 'premake'),
'--file=premake5.lua',
@@ -324,8 +324,10 @@ def run_premake(target_os, action):
'--test-suite-mode=combined',
'--verbose',
action,
- ])
- generate_version_h()
+ ], shell=False)
+
+ if ret == 0:
+ generate_version_h()
def run_premake_clean():

3 comments on commit 20458de

@Parovozik
Parovozik commented on 20458de Sep 11, 2016 edited

Hey. Thanks for your work, this great!
I noticed one problem. Since some build you change the input-output module (controllers). And this is as follows:
-If use the gamepad, everything works well (in those games where it operates today)
-If the disable gamepad and use the keyboard, pressing keys (single press or press n hold) picture often Freeze until the release the key.
I've tried using a different keyboard and even a keyboard emulator (gamepad as a keyboard, through the program Xpadder), the problem is somewhere in the emulator code.
And sometimes (very rarely) frieze of picture can with a gamepad, and to fix it, need to press some times any key on the keyboard.
P.s. Sorry for my bad English :D

@darkstar

You should open an issue for that. Adding it as a comment to a random commit (which has nothing to do with the problem you're describing) is probably not the smartest way to report a bug/regression...

@Parovozik

To Darkstar.
This trouble fixed in last update, i think Dr.Chat read my comment :)

Please sign in to comment.