Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cant add time to datetime #13

Closed
ilyinss opened this issue Mar 6, 2023 · 3 comments
Closed

cant add time to datetime #13

ilyinss opened this issue Mar 6, 2023 · 3 comments

Comments

@ilyinss
Copy link

ilyinss commented Mar 6, 2023

Hello, its me again!

in method you wrote:
dt_tm <- lubridate::as_datetime(paste(dt, " 22:00:00"), tz = "UTC")
then, user cant add a time. You are hardcoding it ((
can you edit it like this:
if user not add time - you paste 22:00
if user add time - you calculate strar map with his time

Sergey

@benyamindsmith
Copy link
Owner

This package aims to replicate the product produced by MapsForMoments. @dieghernan was kind enough to do alot of work for figuring out how to replicate the maps as far as datetime is concerned and learned that this is what MapsForMoments does.

For more reading see Diego's blog in #7 and #10

@ilyinss
Copy link
Author

ilyinss commented Mar 6, 2023

yes, i'm understand it. but MapsForMoments - its commercial service.
i think your library can be more strong than MFM service because it's opensource

@benyamindsmith
Copy link
Owner

@ilyinss Going to close this issue.

I hope you are enjoying the package still!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants