Permalink
Browse files

Merge pull request #7 from mjg17/mjg17/kwalitee

Improve CPANTS Kwalitee rating
  • Loading branch information...
beppu committed Oct 26, 2015
2 parents 5db944b + 0b858a8 commit efc66040956777b70775174cb2b0a1a9f34e4500
View
@@ -52,4 +52,5 @@ t/20_squatting_with_log.t
xt/01_podspell.t
xt/02_perlcritic.t
xt/03_pod.t
xt/04_kwalitee.t
xt/perlcriticrc
View
@@ -27,6 +27,7 @@ WriteMakefile1(
'HTTP::Response' => 0,
'Clone' => 0,
},
MIN_PERL_VERSION => 5.006001,
depend => { distmeta => 'metamunge' }
);
View
@@ -2,8 +2,8 @@ package Squatting;
use strict;
no strict 'refs';
#use warnings;
#no warnings 'redefine';
use warnings;
no warnings 'redefine';
use base 'Class::C3::Componentised';
use List::Util qw(first);
@@ -1,11 +1,9 @@
package Squatting::Controller;
#use strict;
#no strict 'refs';
#use warnings;
#no warnings 'redefine';
#our $AUTOLOAD;
use strict;
no strict 'refs';
use warnings;
no warnings 'redefine';
# constructor
sub new {
View
@@ -1,16 +1,19 @@
package Squatting::Mapper;
#use strict;
#no strict 'refs'
#use warnings;
use strict;
use warnings;
use base 'Continuity::Mapper';
sub get_session_id_from_hit {
my ($self, $request) = @_;
my $app = $self->{app};
my $session_id = $self->SUPER::get_session_id_from_hit($request);
my $path = $request->uri->path;
my ($controller, $params) = &{$app."::D"}($path);
my ($controller, $params);
{
no strict 'refs';
($controller, $params) = &{$app."::D"}($path);
}
my $method = lc $request->method;
my $queue = $controller->{queue}->{$method};
if (defined($queue)) {
View
@@ -1,8 +1,8 @@
package Squatting::On::CGI;
#use strict;
#no strict 'refs';
#use warnings;
use strict;
no strict 'refs';
use warnings;
use CGI;
use CGI::Cookie;
use HTTP::Response;
@@ -2,7 +2,7 @@ package Squatting::On::Continuity;
use strict;
no strict 'refs';
#use warnings;
use warnings;
use Continuity;
use Squatting::Mapper;
use CGI::Cookie;
@@ -0,0 +1,8 @@
package Squatting::On::Squatting;
use strict;
use warnings;
# Placeholder for Squatting::mount()
1;
View
@@ -1,10 +1,10 @@
package Squatting::View;
#use strict;
#use warnings;
#no warnings 'redefine';
use strict;
use warnings;
no warnings 'redefine';
#our $AUTOLOAD;
our $AUTOLOAD;
# constructor
sub new {
@@ -1,5 +1,8 @@
package Squatting::With::AccessTrace;
use strict;
use warnings;
use Data::Dump 'pp';
our $I = 1;
@@ -1,7 +1,7 @@
package Squatting::With::Coro::Debug;
#use strict;
#use warnings;
use strict;
use warnings;
use Coro::Debug;
sub init {
View
@@ -0,0 +1,10 @@
BEGIN { # limited to release test
unless ($ENV{RELEASE_TESTING}) { # or $ENV{AUTHOR_TESTING} for author test
require Test::More;
Test::More::plan(skip_all => 'these tests are for release candidate testing');
}
}
use Test::More;
eval { require Test::Kwalitee::Extra; Test::Kwalitee::Extra->import(qw( )); };
plan( skip_all => "Test::Kwalitee::Extra not installed: $@; skipping") if $@;

0 comments on commit efc6604

Please sign in to comment.