Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart Contract - Marketplace NFTs [@RealFevr] #50

Open
6 tasks done
Ruiub3i opened this issue May 12, 2021 · 7 comments
Open
6 tasks done

Smart Contract - Marketplace NFTs [@RealFevr] #50

Ruiub3i opened this issue May 12, 2021 · 7 comments
Assignees
@Ruiub3i
Labels
Internal Team Issue

Comments

@Ruiub3i
Copy link
Contributor

Ruiub3i commented May 12, 2021 •
edited

Description
Simple Marketplace similar to opensea for basic Sale Use of NFTs
The goal is also to make it agnostic

Features

  • Get NFTs on Sale getAllOnSale() - this has to be done off-chain via the events "SaleCreated" & "SaleCanceled"
  • Put NFT on Sale putERC721OnSale(tokenId, price)
  • Remove NFT from sale removeERC721FromSale(tokenId)
  • Buy NFT buy(tokenId)
  • Set Fee structure for all txs [Admin] setFixedFees(address, percentage)
  • Change currency available to use - ERC20 [Admin] changeERC20(currencyAddress)

Object
ERC721Marketplace
@Ruiub3i Ruiub3i self-assigned this May 12, 2021
@tbem
Copy link
Contributor

tbem commented May 17, 2021

We should have an option just do buy the NFT for the price is listed. Without the bids process.

@tbem
Copy link
Contributor

tbem commented May 19, 2021

We should have a function to return the Marketplace transactions for a NFT getTransactions(tokenID).

@Ruiub3i
Copy link
Contributor Author

Ruiub3i commented Jun 4, 2021

getTransactions should be done via the use of the events proposed below :
Screenshot 2021-06-04 at 12 57 09

@Ruiub3i
Copy link
Contributor Author

Ruiub3i commented Jun 6, 2021 •
edited

  • Only left to add is the perpetual fees per NFT for all the sales done in the marketplace

@tbem
Copy link
Contributor

tbem commented Jun 9, 2021

Add admin functions to Sell Nfts and to cancel sells, in order to reproduce the state of the marketplace in a new marketplace contract.

@tbem
Copy link
Contributor

tbem commented Jul 7, 2021

We want to have the possibility to sell and buy NFTs in BNB only, or in FEVR, or in both.
If we sell NFTs in FEVR we should have the option to reduce marketplace fee amount for this transactions, only.
The putERC721OnSale function should receive an extra param to define the token we want to use. Also the putOnSale event should send the token chosen.

@Ruiub3i
Copy link
Contributor Author

Ruiub3i commented Jul 12, 2021

Request from @tbem

  • Change Currency of use from ERC20 Interface to msg.value directly for v1

Febrero added a commit to Febrero/assets that referenced this issue Sep 24, 2021
@Febrero
Add FEVR token logo and info
8c18e6f 
I would like to request the FEVR logo and token information to be added to TrustWallet. 
I'm the head of blockchain at RealFevr: https://www.linkedin.com/in/pedrofebrero/
You can check RealFevr's smart contracts here: bepronetwork/bepro-js#50
@Febrero Febrero mentioned this issue Sep 24, 2021
Closed
Febrero added a commit to Febrero/assets that referenced this issue Oct 25, 2021
@Febrero
Add FEVR token logo and info
f6b7237 
I would like to request the FEVR logo and token information to be added to TrustWallet.
I'm the head of blockchain at RealFevr: https://www.linkedin.com/in/pedrofebrero/
You can check RealFevr's smart contracts here: bepronetwork/bepro-js#50
@Febrero Febrero mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ruiub3i Ruiub3i

Labels
Internal Team Issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbem @Ruiub3i