Skip to content

Commit

Permalink
hotfix: remove win32 dependency (#12)
Browse files Browse the repository at this point in the history
* don't depend on Win32 modules
* stale Win32 code removed
(it didn't work anyway, so there is no point in packaging it in CPAN releases).
  • Loading branch information
Vyacheslav Matjukhin committed Apr 10, 2011
1 parent bf4f600 commit 8ea1485
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 93 deletions.
4 changes: 4 additions & 0 deletions Changes
@@ -1,6 +1,10 @@
Revision history for Ubic

{{$NEXT}}
Hotfix release (https://github.com/berekuk/Ubic/issues/12):
* don't depend on Win32 modules
* stale Win32 code removed
(it didn't work anyway, so there is no point in packaging it in CPAN releases).

1.25 2011-03-31
* MacOSX support (and probably other POSIX systems too, including FreeBSD)
Expand Down
3 changes: 2 additions & 1 deletion dist.ini
@@ -1,5 +1,5 @@
name = Ubic
version = 1.25
version = 1.26
author = Vyacheslav Matyukhin <mmcleric@yandex-team.ru>
license = Perl_5
copyright_holder = Yandex LLC
Expand All @@ -11,6 +11,7 @@ bundle = @Classic
remove = PodVersion

[AutoPrereqs]
skip = ^Win

[NextRelease]
format = %-7v %{yyyy-MM-dd}d
Expand Down
19 changes: 11 additions & 8 deletions lib/Ubic/Credentials/OS/Windows.pm
Expand Up @@ -3,15 +3,19 @@ package Ubic::Credentials::OS::Windows;
use strict;
use warnings;

use parent qw(Ubic::Credentials);
# ABSTRACT: dummy credentials module

BEGIN {
return if $^O ne 'MSWin32';
=head1 DESCRIPTION
require Win32::pwent;
push @Win32::pwent::EXPORT_OK, 'endgrent';
Win32::pwent->import( qw( getpwent endpwent setpwent getpwnam getpwuid getgrent endgrent setgrent getgrnam getgrgid ) );
}
This module does nothing and always says that credentials are good.
If you are interested in proper Win32 credentials support, look for the patch I<9581a96> in git repo.
You might also want to contact CPAN user I<MITHALDU>, he provided that patch and was generally interested in Win32 port some time ago.
=cut

use parent qw(Ubic::Credentials);

sub new {
my $class = shift;
Expand All @@ -24,4 +28,3 @@ sub eq { 1 }
sub set {}

1;

8 changes: 0 additions & 8 deletions lib/Ubic/Service.pm
Expand Up @@ -15,14 +15,6 @@ use warnings;
=cut

BEGIN {
return if $^O ne 'MSWin32';

require Win32::pwent;
push @Win32::pwent::EXPORT_OK, 'endgrent';
Win32::pwent->import( qw( getpwent endpwent setpwent getpwnam getpwuid getgrent endgrent setgrent getgrnam getgrgid ) );
}

use Ubic::Result qw(result);

=head1 DESCRIPTION
Expand Down
76 changes: 0 additions & 76 deletions lib/Ubic/UserGroupInspection.pm

This file was deleted.

0 comments on commit 8ea1485

Please sign in to comment.