New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pod tests, which are generated by plugins #75

Merged
merged 1 commit into from Feb 16, 2015

Conversation

Projects
None yet
2 participants
@rjbs
Contributor

rjbs commented Feb 16, 2015

Full disclosure: I looked into Ubic in order to carry out my CPAN Pull Request Challenge assignment.

I was surprised to see that you use dzil, but have pod tests in the repo. I looked at your latest CPAN release and saw that you have pod tests in the release twice: one set is added by plugins, and only run for the author. The other set are there by hand, and run for everyone.

Beyond the duplication, this means that if a new Pod::Simple release later adds new problems, Ubic can be broken for installing users, rather than releasing authors. This will result in gnashing of teeth.

This PR removes the run-for-everybody and managed-by-hand tests.

berekuk added a commit that referenced this pull request Feb 16, 2015

Merge pull request #75 from rjbs/dupe-pod-tests
remove pod tests, which are generated by plugins

@berekuk berekuk merged commit 23375d5 into berekuk:master Feb 16, 2015

@berekuk

This comment has been minimized.

Owner

berekuk commented Feb 16, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment