Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Hallo toolbar shown in wrong place on keyboard selection #25

Closed
bergie opened this issue Nov 14, 2011 · 3 comments · Fixed by #26
Closed

Hallo toolbar shown in wrong place on keyboard selection #25

bergie opened this issue Nov 14, 2011 · 3 comments · Fixed by #26

Comments

@bergie
Copy link
Owner

bergie commented Nov 14, 2011

After merging the pull request #24, the Hallo toolbar is now shown inconsistently:

  • When selection is made with mouse, the toolbar is shown under the selection, as intended
  • When selection is made with keyboard, the toolbar is shown above the element that Hallo is enabled for

Ping @rryter for getting this fixed.

@rryter
Copy link
Contributor

rryter commented Nov 15, 2011

Hello bergie

I have spotted the issue: on the "keyup" event the event properties "event.pageY & event.pageX" are undefined.
So the function "_getToolbarPosition" can not position the Toolbar correctly.

I'm trying to find a workaround for this now.

@bergie
Copy link
Owner Author

bergie commented Nov 15, 2011

@rryter the _getCaretPosition method provides such a workaround, but for some reason is not called any longer:

https://github.com/bergie/hallo/blob/master/hallo.coffee#L252

@bergie
Copy link
Owner Author

bergie commented Nov 15, 2011

Fixed by #26

@bergie bergie closed this as completed Nov 15, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants