Halloheadings plugin rewrite #126

merged 6 commits into from Jan 14, 2013


None yet

2 participants

madwire commented Nov 30, 2012


Ive rewritten the halloheading plugin to make better use of the button widget and make it work in IE (current one doesn't work in IE at all).

Tested In:

  • Chrome 23
  • Safari 6
  • IE 8
  • IE 7

I will be looking at some other plugins for IE compatibility over the next few days.

Thanks for all your hard work, what a great little editor it is.

@bergie bergie commented on an outdated diff Nov 30, 2012
@@ -39,16 +42,28 @@
_init: ->
@button = @_prepareButton() unless @button
@element.append @button
- queryState = (event) =>
- return unless @options.command
- try
- @checked document.queryCommandState @options.command
- catch e
- return
+ if @options.queryState == true
bergie Nov 30, 2012 Owner

This could probably use is instead of ==

madwire commented Nov 30, 2012

Yeah no problem will change that!

@madwire madwire changed == to 'is'
to align with the rest of the codebase
@bergie bergie merged commit 6ed1b4e into bergie:master Jan 14, 2013

1 check passed

default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment