Fix rspec dependency #451

Merged
merged 3 commits into from Apr 7, 2013

Conversation

Projects
None yet
4 participants
Contributor

justincampbell commented Mar 29, 2013

We require 'rspec/mocks/standalone' in Berkshelf::Mocks, but Berkshelf does not have a dependency on RSpec.

Contributor

justincampbell commented Mar 29, 2013

Alternatively we could just rescue LoadError

Contributor

sethvargo commented Mar 29, 2013

Can we use something prefixed with BERKSHELF to avoid conflicts and be more explicit?

Contributor

justincampbell commented Mar 29, 2013

I think it's pretty conventional to set RUBY_ENV to test when testing. We could do BERKSHELF_ENV but I don't see the difference, unless someone was testing Berkshelf from another project (in which case I still think RUBY_ENV is fine).

But like I said, maybe rescuing from a LoadError is simpler.

Member

reset commented Mar 29, 2013

@justincampbell RUBY_ENV is pretty standard. I like this more than the LoadError.

👍

Contributor

sethvargo commented Mar 29, 2013

Can we add a note to the spec_helper saying something like:

# We set this flag to load additional test materials during cucumber runs since aruba runs in a subprocess
Contributor

ivey commented Apr 6, 2013

Can we merge this?

reset added a commit that referenced this pull request Apr 7, 2013

@reset reset merged commit b616f5f into master Apr 7, 2013

1 check failed

default The Travis build failed
Details

@reset reset deleted the fix-rspec-dependency branch Apr 7, 2013

@lamont-granquist lamont-granquist locked and limited conversation to collaborators Jun 16, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.