Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1.0 - Incorrect Column Retrieval in PHP 8.x #159

Open
spencerfinnell opened this issue May 11, 2023 · 0 comments
Open

2.1.0 - Incorrect Column Retrieval in PHP 8.x #159

spencerfinnell opened this issue May 11, 2023 · 0 comments
Assignees
@JJJ
Labels
component-query The Query class type-bug A problem in the code
Milestone
3.0.0

Comments

@spencerfinnell
Copy link

Hey @JJJ,

I believe this change b8fdfc6 in release/2.1.0 is having unintended side effects in PHP 8.x

In 8.x the $columns value remains the same as the first time it is retrieved.
In 7.4 the $columns value updates with new class instances.

You can see the difference here: https://onlinephp.io/c/b236e

Screenshot 2023-05-11 at 4 30 00 PM

I believe it's because of this: https://wiki.php.net/rfc/static_variable_inheritance
@JJJ JJJ self-assigned this May 12, 2023
@JJJ JJJ added the type-bug A problem in the code label May 12, 2023
@JJJ JJJ added this to the 3.0.0 milestone May 12, 2023
@JJJ JJJ added the component-query The Query class label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JJJ JJJ

Labels
component-query The Query class type-bug A problem in the code
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@JJJ @spencerfinnell