From 2b7a8106da69747012abe3af92b09892c41343da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johannes=20Wu=CC=88rbach?= Date: Mon, 15 Jul 2013 11:40:59 +0200 Subject: [PATCH] Adds missing close callback. --- lib/sauce-connect-launcher.js | 7 ++++++- test/sauce-connect-launcher.test.js | 10 ++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/sauce-connect-launcher.js b/lib/sauce-connect-launcher.js index aeeb5b0..6e26c66 100644 --- a/lib/sauce-connect-launcher.js +++ b/lib/sauce-connect-launcher.js @@ -190,7 +190,12 @@ function run(options, callback) { openProcesses.push(child); - child.close = function () { + child.close = function (closeCallback) { + if (closeCallback) { + child.on("close", function () { + closeCallback(); + }); + } child.kill("SIGTERM"); }; } diff --git a/test/sauce-connect-launcher.test.js b/test/sauce-connect-launcher.test.js index b7789be..82ecaf6 100644 --- a/test/sauce-connect-launcher.test.js +++ b/test/sauce-connect-launcher.test.js @@ -90,6 +90,16 @@ describe("Sauce Connect Launcher", function () { done(); }); }); + + it("should execute a provided close callback", function (done) { + sauceConnectLauncher(sauceCreds, function (err, sauceConnectProcess) { + if (err) { throw err; } + expect(sauceConnectProcess).to.be.ok(); + sauceConnectProcess.close(function () { + done(); + }); + }); + }); } });