Replace $ with jQuery for compatibility #95

Merged
merged 3 commits into from May 12, 2012

Conversation

Projects
None yet
3 participants
@tschmitz

I was running into trouble trying to use best_in_place on an old app that needs to be running Prototype for compatibility reasons. This change replaces instances of $ with jQuery, because $ is can be assigned to Prototype.

@albertbellonch

This comment has been minimized.

Show comment
Hide comment
@albertbellonch

albertbellonch Jan 28, 2012

Collaborator

Hello @tschmitz,

There is no reason to update the version of Best In Place manually, as we are now on 1.0.6.

We'll happily merge the pull request after that being fixed.

Thanks

Collaborator

albertbellonch commented Jan 28, 2012

Hello @tschmitz,

There is no reason to update the version of Best In Place manually, as we are now on 1.0.6.

We'll happily merge the pull request after that being fixed.

Thanks

@tschmitz

This comment has been minimized.

Show comment
Hide comment
@tschmitz

tschmitz Jan 30, 2012

Hi @albertbellonch,

Thanks for responding! I just reverted the version change. Thanks!

Tim

Hi @albertbellonch,

Thanks for responding! I just reverted the version change. Thanks!

Tim

@rogercampos rogercampos merged commit 73e48fa into bernat:master May 12, 2012

@rogercampos

This comment has been minimized.

Show comment
Hide comment
@rogercampos

rogercampos May 12, 2012

Collaborator

Thanks @tschmitz and sorry for the big delay, i just have some time to work on best in place now.

Collaborator

rogercampos commented May 12, 2012

Thanks @tschmitz and sorry for the big delay, i just have some time to work on best in place now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment